Advanced repeat rules UI #8422
Open
Advanced repeat rules UI #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
c8134f0 to
040498f
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
30a7bb4 to
7aefc39
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
2 times, most recently
from
ffbc61b to
be4c63a
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
be4c63a to
e3da4ff
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
from
a0e43a2 to
4ff0a1d
Compare
tutao-mac
force-pushed
the
8046-parse-advanced-repeat-rules
branch
3 times, most recently
from
cf65d58 to
7446664
Compare
murilopereirame
force-pushed
the
8046-parse-advanced-repeat-rules
branch
10 times, most recently
from
d0e574b to
945ddb4
Compare
Base automatically changed from
8046-parse-advanced-repeat-rules
to
dev-calendar
February 13, 2025 04:19
murilopereirame
force-pushed
the
dev-calendar
branch
from
945ddb4 to
199b04d
Compare
Selecting the time frame for rules will now render day/week/month/year correctly
Introduce WeekdaySelectorButton component
Currently, reading BYDAY Rules from an existing event works, however writing them has not been added yet.
Upon closing the editor it now passes the values to the model
WeekRepetitionSelector component still needs to be finished and hooked up to the CalendarWhenModel
Fix undefined weekdays being written on AdvancedRules
When changing the date outside of the RepitionEditor, the advanced repeat rules would still use the old weekday. Now, when changing the date, it will also change the advanced repeat rules that have been configured
Patrik-wav
force-pushed
the
8047-advanced-repeat-rules-ui
branch
from
cabb90a to
03f14a6
Compare
murilopereirame
requested changes
Feb 14, 2025
| const options: IntervalOption[] = [ | ||
| { | ||
| value: 0, | ||
| ariaValue: "same day", |
There was a problem hiding this comment.
Use the translation as aria value so screen readers can announce the correct value for the options
| const bydayRules = whenModel.advancedRules.filter((rule) => rule.ruleType == ByRule.BYDAY) | ||
| if (bydayRules.length == 1) { | ||
| const weekday: Weekday = Object.values(Weekday)[DateTime.fromJSDate(date).weekday - 1] | ||
| const regex = /^-?\d/g // Regex for extracting the first digit from interval |
There was a problem hiding this comment.
This will fail if the user has imported an event with a ByDay rule with +2TH (RFC allows this).
Either we take care of this during import, or we adapt this regex to support the + sign
| * we only specify what weekday of the month this event repeats on. (Ex.: BYDAY=2TH = Repeats on second THURSDAY of every month) | ||
| * In case weekdays.length() == 0 && interval == 0, no BYDAY Rule shall be written, as the event will repeat on the same DAY every month. | ||
| */ | ||
| private async createAdvancedRulesFromWeekdays(weekdays: Weekday[], interval?: number): Promise<AdvancedRepeatRule[]> { |
| @@ -486,24 +486,122 @@ export const createCustomEndTypeOptions = (): ReadonlyArray<RadioGroupOption<End | |||
| ] | |||
| } | |||
|
|
|||
| export const createRepeatRuleEndTypeValues = (): SelectorItemList<EndType> => { | |||
| export const weekdayToTranslation = (): Array<WeekdayToTranslation> => { | |||
There was a problem hiding this comment.
I think we can change it to an Array instead of a function. I'm not sure if it will break any rendering
| options: this.repetitionOptions, | ||
| noIcon: false, | ||
| expanded: false, | ||
| tabIndex: Number(TabIndex.Programmatic), |
There was a problem hiding this comment.
This takes the select component out of the element three, making it unreachable through tabbing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8047